From be8405cdd6f46fec40f26ba045a46151dbab1af2 Mon Sep 17 00:00:00 2001 From: Jerome St-Louis Date: Mon, 13 Jul 2020 19:44:07 -0400 Subject: [PATCH] ecere/gfx/3D/models/E3D: Fixed leaking Bitmap from second incref when adding to texturesByID - TODO: Review whether code ever gets there with a 0 ref Bitmap (Debug printout added) --- ecere/src/gfx/3D/models/e3d/e3dRead.ec | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ecere/src/gfx/3D/models/e3d/e3dRead.ec b/ecere/src/gfx/3D/models/e3d/e3dRead.ec index 78d086a9e1..dd36028747 100644 --- a/ecere/src/gfx/3D/models/e3d/e3dRead.ec +++ b/ecere/src/gfx/3D/models/e3d/e3dRead.ec @@ -366,7 +366,11 @@ static void readBlocks(E3DContext ctx, File f, DisplaySystem displaySystem, E3DB else { Bitmap bitmap = data; - incref bitmap; +#ifdef _DEBUG + if(!bitmap._refCount) + PrintLn("WARNING: E3D/textureID bitmap with 0 refs"); +#endif + //incref bitmap; ctx.curTextureID = id; ctx.texturesByID[id] = bitmap; }