Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a more thorough test for TELEMAC #177

Open
tomsail opened this issue Mar 21, 2024 · 3 comments
Open

add a more thorough test for TELEMAC #177

tomsail opened this issue Mar 21, 2024 · 3 comments

Comments

@tomsail
Copy link
Collaborator

tomsail commented Mar 21, 2024

I am writing this to not forget it:

Before merging the telemac branch, I'd be nice to

  • add a max value test in test_telemac.py
@tomsail
Copy link
Collaborator Author

tomsail commented May 9, 2024

This issue should have be addressed with 5c00dcc
We can close when merging #176

@pmav99
Copy link
Collaborator

pmav99 commented May 9, 2024

For the record, you could add a line in the commit message with the text fixes #177 and it would be closed automatically upon merge.

@tomsail
Copy link
Collaborator Author

tomsail commented May 27, 2024

After discussion, a more thorough assertion for TELEMAC tests needs to be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants