Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of consistency for ECL icons #3702

Open
joarod-eu opened this issue Oct 30, 2024 · 2 comments
Open

Lack of consistency for ECL icons #3702

joarod-eu opened this issue Oct 30, 2024 · 2 comments

Comments

@joarod-eu
Copy link
Contributor

joarod-eu commented Oct 30, 2024

Expected behavior

Icons must have the same variants in all their versions. Several outline and filled versions are missing.
Also two icons have the same design but are declared with two different names.

Actual behavior

Lack of consistency in icon declinations, for example:

  • Information-round icon has no outline version
  • Check-filled has no outline version (with the circle)
  • Warning-round has no outline version
  • Play icon has no outline version
  • Minus-outline has no filled version
  • Log-in-outline and log-in are both outline, but there is no filled version
  • Multiple-files and copy icon are duplicated with the same design
  • Arrow, corner-arrow, solid-arrow has only one direction (the other 3 directions are missing, and please don't tell to use CSS to rotate)
  • Mastodon color is not updated (current color is more violet)
  • Several Social media icons has the left and bottom side of the circle cut off (ex: spotify-color, spotifym pinterest-color, pinterest-negative, pinterest)

Steps to reproduce the issue

Just go to the Iconography page:
https://ec.europa.eu/component-library/ec/guidelines/iconography/

Extra info

I'm already developing some icons missing to move forward in our web development (DG SANTE), I don't mind to open a PR and add several of the icons missing if that will help.
If not, please let me know the right person in the design department to contact and share these svg items.
Thanks

@emeryro
Copy link
Contributor

emeryro commented Oct 30, 2024

Hello, thanks for your report.
We will check that with the designers and come back to you.
What I can already tell, is that rotating arrow icons is indeed the way we use them. You can find some helpers for that on ECL website

Out of curiosity, could you tell me more about the usage you have of ECL? As it seems, you are using directly to build your website. I also saw that you forked the project in the past. Are you using a custom version of it?
Thanks

@joarod-eu
Copy link
Contributor Author

joarod-eu commented Oct 31, 2024

Hello @emeryro
Thanks for your quick reply, let me know if the designers would like to exchange/contact me for the icons I already have.

I will ping you later via Teams to give you more info about the DG Sante platform and framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants