feat: intro univ3 and prep seeding scripting for ebtc/wbtc pool #18
Conversation
There was a problem hiding this comment.
Review
- The UniV3 helpes and library were integrally imported from the badger-multisig GreatApeSafe. These include helpers to functions to create and manage liquidity positions, swap, collect fees and visualize the state of LPs.
- The required mainnet addresses, as well as the Vault and Trops addresses, were added to the address book.
- A draft for the eBTC pool creation and seeding was developed:
- Pool is created using the 0.05% fee tier as planned
- Pool is initialized for a 1:1 price
- Positions are minted for each one of the planned ranges using the percentages predefined by BALCO.
- Used LIQ as a dummy token while eBTC is deployed to mainnet
@petrovska-petro Implementations LGTM, my only comment is that we should use this chance to add unit tests for at least the operations that we intend to use. It is ok if these are meant to be run against mainnet instead of Sepolia (as opposed to the existing ones).
My concern relates to the issue in which, not too long ago, we almost execute a swap using this library that had a misestimation of the min_out and could have resulted in drain of value. Considering how often we will use this library, I think we need higher certainty into its accuracy.
Feat/cli cdp management
|
Tackles #11 |
|
great suggestion @sajanrajdev i added tests on the last commits for the actions intended for now one thing im still researching is something to note on the run: im still investigating if related to tick spacing |
|
pushed 5241b91 which i think was a mistaken assumptions inherit from the fact that badgerwbtc and ethgtc shared the same fee tier, but this one suggested in the forum is meant to be 0.05% which by result the tick spacing will be different. now it should represent a more precise representation of the nft positions created given the price targets. will be great if you could also provide feedback if you see something im missing out @sajanrajdev |
scripts/cdp_management_lens.py
Outdated
| _, | ||
| _, | ||
| _, | ||
| ) = safe.ebtc.cdp_manager.Cdps(cdp_id) |
There was a problem hiding this comment.
same comment added here #19 (comment)
There was a problem hiding this comment.
suggested added in 390a7d9
| token_0_init_seeding_amount = 2.5e8 if token0 == wbtc.address else 2.5e18 | ||
| token_1_init_seeding_amount = 2.5e18 if token1 == liq.address else 2.5e8 | ||
|
|
||
| # single-side lp only ebtc |
There was a problem hiding this comment.
this is still sort of a placeholder in light of non ebtc in prod. order of which one will be token0 or token1 will depending on the internally ordering of the each token address itself when deploying the pool
https://github.com/Uniswap/v3-core/blob/main/contracts/UniswapV3Factory.sol#L41
| token_1_init_seeding_amount * PCT_40, | ||
| ) | ||
|
|
||
| # single-side only wbtc |
There was a problem hiding this comment.
same as #18 (comment)
There was a problem hiding this comment.
Additional Review
- Introduces a test case for an pool creation using the expected specs for eBTC/wBTC (with LIQ as dummy token1 for now)
- Introduces a test case for the treasury's position creation for the 1 - 1.01 range
- Allows for tick spacing to be changed dynamically for pools of different fee tiers when minting new positions
- All tests are passing:
LGTM
| positions = treasury.uni_v3.nonfungible_position_manager.positions(token_id) | ||
|
|
||
| # TODO: rounding to 4 decimal places, values are not matching the expected? | ||
| price_lower_ticket = round( |
There was a problem hiding this comment.
Minor typo in here. Mean ticker or tick, right?
There was a problem hiding this comment.
good catch, fixed in 9d360d7
tackles #8