Code copied from the keycloak-js library

[lgleim]

I noticed that you seem to have copied/rewritten large chunks of code from the keycloak-js library (https://github.com/keycloak/keycloak/tree/master/adapters/oidc/js/src/main/resources). Since that library is maintained and officially supported by the keycloak core team, wouldn't it be better to wrap the library instead of duplicating its code? If this was a conscious decision, could you provide some insight into the reasoning that lead to this approach?

If there is no reason not to wrap keycloak-js, would you consider refactoring this project in a way that it uses the official client instead? Would you accept a pull request if you are not available to put in the work yourself?

Given that your code is much more readable then the current keycloak-js version, have you tried to get in contact with their core team to recontribute your code?

[ebondu]

I hope a native typescript version of the lib will help for integration. The official angular2 example shows us how to wrap the keycloak-js but for now it is not a separate dependency you can just import in your project with npm to easily enable keycloak auth/authz. Moreover, typescript is supposed to help to organize the code so the idea is also to get a more structured / readable / extensible code than the JS.

When I started the migration, no "working" wrappers was available but maybe it is the case now and maybe it is a better approach.

Cons with this approach are obviously the official support, bugfix, documentation, etc., but it will be the same problem with all non official wrappers.

It would be nice that the official keycloak core team looks into existing projects (wrappers & this lib) and decide to officially support/clone one of them. It would be more confortable for me to contribute to an official angular2 / typescript lib instead of developping my own lib.

You may have a look to this discussion.

[marcelnem]

Is there any progress on this? I find the official keyclak-authz.js unusable with Angular. I have opened an issue for keycloak about this: https://issues.jboss.org/browse/KEYCLOAK-7021

[ebondu]

I would be pleased to see the repo officially supported ;). I planned to support angular5+ (new http provider) in the next months.