Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include review time in output checking dashboard #137

Open
LFISHER7 opened this issue Feb 29, 2024 · 4 comments
Open

Include review time in output checking dashboard #137

LFISHER7 opened this issue Feb 29, 2024 · 4 comments

Comments

@LFISHER7
Copy link

LFISHER7 commented Feb 29, 2024

There is a WIP to extract review time from github reactions here - https://github.com/ebmdatalab/metrics/tree/output-checking-reactions

This still needs to be surfaced in the dashboards.

There's no particular rush for this but it may be useful to have in place to monitor the impact of airlock on review time.

@lucyb
Copy link
Collaborator

lucyb commented Mar 4, 2024

Hey @LFISHER7. I'm sorry this didn't get done earlier. We won't be able to finish it immediately and I'm not sure which team should be doing the work. However, I don't want to forget about it, so I'm moving it into "Later" for the time-being (I've started a slack conversation with Peter too).

@inglesp
Copy link

inglesp commented Mar 14, 2024

Our current plan is to record the timings of all events in Airlock's database, which would make producing reports about review time straightforward, without having to pull reaction times from Slack

How important is it that we are able to compare Airlock with what came before?

@LFISHER7
Copy link
Author

@CLStables was keen to have some metrics to measure the impact of Airlock - that's the main reason we've continued to use reactions

@CLStables
Copy link

Thanks @LFISHER7! I'm not sure how much data you think we need for this @inglesp? It might be that the emoji reactions to date are enough to get a rough baseline to compare against, and people can stop doing it (if it's a pain?). If it's possible to get that data out as a one-off then I don't think it necessarily needs to go into a dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants