Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should model_parameters(<a mixed model>) use ci_method = "S"/"KR" by default? #989

Open
mattansb opened this issue Jul 9, 2024 · 4 comments
Labels
Question ❓ Further information is requested

Comments

@mattansb
Copy link
Member

mattansb commented Jul 9, 2024

The current default for mixed models is to use residual dfs, but these are counter conservative.
Should we default (when possible) to use Satterthwaite or Kenward-Roger dfs instead?

@strengejacke
Copy link
Member

I'm not sure if this should be the default. Maybe Sattherthwaite, but K-R can be really slow on large data sets.

Unlike many (or every?) other software, model_parameters() exactly describe the approximation methods, so we're already very transparent, which kind of DF are used to compute the p-values, so I would also be fine when we change nothing. But I'm open to switching to SW (not K-R though).

@bwiernik
Copy link
Contributor

The performance of the various approximations varies so much by model type and features (eg number of clusters, cluster size heterogeneity) that it's not clear to me which if any is most reasonable to choose as a default.

Cf https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4458010/ vs https://link.springer.com/article/10.3758/s13428-016-0809-y

Perhaps changing to S df for gaussian models but sticking with residual or between-within for other families?

@mattansb
Copy link
Member Author

Do have any support for dfs for none gaussian models?

Anyway, I support this:

Perhaps changing to S df for gaussian models

@strengejacke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question ❓ Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants