Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports without the single folder letter #3543

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Dec 30, 2024

noticed while testing in #3533


We must not change the one in r/init.py

from easybuild.easyblocks.r.r import *

to be

from easybuild.easyblocks.r import *

else we get

$ eb R-4.4.2-gfbf-2024a.eb -D
== Temporary log file in case of crash /tmp/eb-jcktr5ls/easybuild-58_vio1o.log
ERROR: Failed to process easyconfig /home/simon/work/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.4.2-gfbf-2024a.eb: Failed to import EB_R easyblock: Failed to import EB_R from easybuild.easyblocks.r: module 'easybuild.easyblocks.r' has no attribute 'EB_R'

@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS iccifort-2020.4.304.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u08b - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/branfosj/974209c02a41daf568d78def848f8d3b for a full test report.

@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Mamba-23.1.0-4.eb
  • SUCCESS Mamba-23.11.0-0.eb
  • SUCCESS Mamba-4.14.0-0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/3b244eccb8816512db3d5e66e85d68ef for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though i think we should review what include.py does with included easyblocks.

@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS intel-compilers-2022.0.2.eb
  • SUCCESS intel-compilers-2023.2.1.eb
  • SUCCESS intel-compilers-2024.2.0.eb
  • SUCCESS intel-compilers-2025.0.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/4cbe1f2eb24c39f8ecbf1859d5f340f7 for a full test report.

@Micket Micket merged commit dfb6184 into easybuilders:5.0.x Dec 30, 2024
19 checks passed
@branfosj branfosj deleted the fix_imports branch December 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants