Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METIS easyblock: No support for preconfigopts #1301

Open
klust opened this issue Nov 28, 2017 · 0 comments
Open

METIS easyblock: No support for preconfigopts #1301

klust opened this issue Nov 28, 2017 · 0 comments

Comments

@klust
Copy link

klust commented Nov 28, 2017

The METIS easyblock currently does not honour preconfigopts for METIS version 5 and above (didn't check for earlier versions). I think this could be easily fixed by modifying line 62 of metis.py to
cmd = "%s make %s config prefix=%s" % (self.cfg['preconfigopts'], self.cfg['configopts'], self.installdir)

The advantage of this would be that rather than using a patch file to set the desired integer and floating point data types in include/metis.h, this could then be done using sed through preconfigopts, e.g.,
preconfigopts = 'sed --in-place=".orig" '
preconfigopts += ' 's/#define IDXTYPEWIDTH./#define IDXTYPEWIDTH 32/; '
preconfigopts += ' s/#define REALTYPEWIDTH.
/#define REALTYPEWIDTH 64/' include/metis.h && '

This would make it much easier to compile METIS for various choices of the data types as it would no longer be needed to generate the (currently very trivial) patch file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant