-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Tailwilnd support #43
Comments
There are a few things I think that need worked on to make this work:
|
The code is a bit inprogress but you can check out what I've been working on here: https://github.com/SweenyStudio/easyblocks/tree/merged-customisations |
I have submited a PR for this - #44 |
Hey @timoconnellaus you're doing great work here. I know it's an overwhelming task, a lot of digging into the deep internals of Easyblocks. We've been thinking about Tailwind for some time already and I think it could be done differently. Actually with changes that are not huge we could detach from Stitches completely and open up for any styling solution, Tailwind would be just a "module", equal to a current Stitches renderer. I can help you with that, I'll schedule a day next week to build a POC. Will update as soon as I have sth. |
I want to start a discussion on tailwind support for easyblocks. I've been working on a POC of this. The way it works is this:
Add a special prop in the styles function tw that returns classnames for no code components
We still use the no code components as usual - but now they have a className property automatically applied. For example, if we defined the backgroundColor of Root to #ffffff then the component deefined like this
would have the className
And if we defined it using responsive values for lg = #000000 and xl = #ffffff the className would be
in compileComponent.tsx we decode the $res object created in the props.tw and add it to a __className attribute on the styled object. This logic is complex and handles doing this:
In ComponentBuilder.tsx we move the __className to a prop on the react element
To handle actually rendering the tailwind css we leave that actually up to the person using the library. To make that easier, we add a subscribe callback to the editorWindowAPI that allows for receiving events that happen e.g. renderableContent
This can be used in the the project calling the EasyblocksEditor to scan editorWindowAPI.compiled to look for tailwind classes and update the CSS
In our case we have this library to generate CSS (https://github.com/mhsdesign/jit-browser-tailwindcss) and then we update the CSS in nextjs like this
I will submit a PR for this after we have some done more testing to make sure it is all working
We're currently converting the example components to use tailwind
The rationale of putting the logic in the styles function is that this makes moving over existing components to use tailwind. It also makes converting the logic more straightforward. We had tried using a separate tailwind function but the extensive amount of logic to get it working cause tons of issues and edge cases to deal with. Integrating into styles was more reliable by far
The text was updated successfully, but these errors were encountered: