Merge pull request #5 from easybill/v0.2.2

v0.2.2
easybill · Oct 29, 2024 · 7600164 · 7600164
2 parents a39b487 + 38104f4
commit 7600164
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/src/main/java/io/github/easybill/Controllers/ValidationController.java b/src/main/java/io/github/easybill/Controllers/ValidationController.java
@@ -33,24 +33,19 @@ public ValidationController(IValidationService validationService) {
                 description = "The submitted XML is valid "
             ),
             @APIResponse(
-                responseCode = "400",
-                description = "Schematron validation for the submitted XML failed. Response will contain the failed assertions"
+                responseCode = "422",
+                description = "The provided XML could not be used for validation"
             ),
         }
     )
     public RestResponse<@NonNull ValidationResult> validation(
         InputStream xmlInputStream
     ) throws Exception {
-        ValidationResult result = validationService.validateXml(xmlInputStream);
-
-        if (result.isValid()) {
-            return RestResponse.ResponseBuilder
-                .ok(result, MediaType.APPLICATION_JSON)
-                .build();
-        }
-
         return RestResponse.ResponseBuilder
-            .create(RestResponse.Status.BAD_REQUEST, result)
+            .create(
+                RestResponse.Status.OK,
+                validationService.validateXml(xmlInputStream)
+            )
             .type(MediaType.APPLICATION_JSON)
             .build();
     }

diff --git a/src/test/java/io/github/easybill/ValidationControllerTest.java b/src/test/java/io/github/easybill/ValidationControllerTest.java
@@ -203,7 +203,7 @@ void testValidationEndpointWithInvalidPayload(
             .when()
             .post("/validation")
             .then()
-            .statusCode(400)
+            .statusCode(200)
             .contentType(ContentType.JSON)
             .body("is_valid", equalTo(false))
             .body("errors", not(empty()));