Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function: Share names can conflict with Letterbox routes #20

Open
johanbove opened this issue Apr 16, 2022 · 0 comments
Open

Function: Share names can conflict with Letterbox routes #20

johanbove opened this issue Apr 16, 2022 · 0 comments

Comments

@johanbove
Copy link

johanbove commented Apr 16, 2022

Situation:

  • User creates a share in Letterbox called "settings"
  • Now the "/settings" page can no longer be reached because of the route name conflict

Solution (options):

  1. Prevent users for naming shares that are the same as Letterbox routes
  2. Move the Letterbox routes so they won't conflict with share names
  3. Always prefix the share name in the url with the "+" sign
  4. 1 + 2 + 3
@johanbove johanbove changed the title Function: Share names should be filtered for reserved words used in letterbox Function: Share names can conflict with Letterbox routes Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant