Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock ops based on computed key rather than LLB digest #61

Merged
merged 1 commit into from
May 21, 2024

Conversation

mikejholly
Copy link
Contributor

@mikejholly mikejholly commented May 17, 2024

In some cases, the LLB vertex digest is not a reliable way to disambiguate operations. This is leading to duplicated execs.

Example:

VERSION 0.8

PROJECT earthly-technologies/core

test:
  FROM alpine
  RUN echo "before copy"
  COPY input .
  RUN echo "after copy"

Before:

image

After:

image

earthly/earthly#4130

@alexcb alexcb self-requested a review May 21, 2024 16:49
Copy link
Contributor

@alexcb alexcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please squash your commits.

@mikejholly mikejholly merged commit d4e630c into earthly-next May 21, 2024
6 of 7 checks passed
@mikejholly mikejholly deleted the mh/next-dupe-after-copy branch May 21, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants