Remove globals & refactor into structs #165
Annotations
9 errors and 1 warning
Generate annotations:
frontend/dockerfile/dockerfile_test.go#L1811
=== RUN TestIntegration/TestCmdShell/worker=containerd-rootless/frontend=builtin
=== PAUSE TestIntegration/TestCmdShell/worker=containerd-rootless/frontend=builtin
=== CONT TestIntegration/TestCmdShell/worker=containerd-rootless/frontend=builtin
dockerfile_test.go:1811:
Error Trace: /src/frontend/dockerfile/dockerfile_test.go:1811
/src/util/testutil/integration/run.go:91
/src/util/testutil/integration/run.go:205
Error: Not equal:
expected: []string(nil)
actual : []string{"test"}
Diff:
--- Expected
+++ Actual
@@ -1,2 +1,4 @@
-([]string) <nil>
+([]string) (len=1) {
+ (string) (len=4) "test"
+}
Test: TestIntegration/TestCmdShell/worker=containerd-rootless/frontend=builtin
sandbox.go:128: stdout: /usr/bin/sudo -u #1000 -i CONTAINERD_ROOTLESS_ROOTLESSKIT_STATE_DIR=/tmp/bktest_containerd2826081050/rootlesskit-containerd CONTAINERD_ROOTLESS_ROOTLESSKIT_NET=host CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=none CONTAINERD_ROOTLESS_ROOTLESSKIT_FLAGS=--mtu=0 containerd-rootless.sh -c /tmp/bktest_containerd2826081050/config.toml
sandbox.go:128: stderr: /usr/bin/sudo -u #1000 -i CONTAINERD_ROOTLESS_ROOTLESSKIT_STATE_DIR=/tmp/bktest_containerd2826081050/rootlesskit-containerd CONTAINERD_ROOTLESS_ROOTLESSKIT_NET=host CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=none CONTAINERD_ROOTLESS_ROOTLESSKIT_FLAGS=--mtu=0 containerd-rootless.sh -c /tmp/bktest_containerd2826081050/config.toml
sandbox.go:131: > StartCmd 2024-03-21 23:29:09.712042853 +0000 UTC m=+3.122157282 /usr/bin/sudo -u #1000 -i CONTAINERD_ROOTLESS_ROOTLESSKIT_STATE_DIR=/tmp/bktest_containerd2826081050/rootlesskit-containerd CONTAINERD_ROOTLESS_ROOTLESSKIT_NET=host CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=none CONTAINERD_ROOTLESS_ROOTLESSKIT_FLAGS=--mtu=0 containerd-rootless.sh -c /tmp/bktest_containerd2826081050/config.toml
sandbox.go:131: time="2024-03-21T23:29:09Z" level=warning msg="The host root filesystem is mounted as \"master:293\". Setting child propagation to \"rslave\" is not supported."
sandbox.go:131: time="2024-03-21T23:29:09Z" level=warning msg="containerd config version `1` has been deprecated and will be removed in containerd v2.0, please switch to version `2`, see https://github.com/containerd/containerd/blob/main/docs/PLUGINS.md#version-header"
sandbox.go:131: time="2024-03-21T23:29:09.765045410Z" level=info msg="starting containerd" revision=8c087663b0233f6e6e2f4515cee61d49f14746a8 version=v1.7.7
sandbox.go:131: time="2024-03-21T23:29:09.798162467Z" level=info msg="loading plugin \"io.containerd.event.v1.exchange\"..." type=io.containerd.event.v1
sandbox.go:131: time="2024-03-21T23:29:09.798205297Z" level=info msg="loading plugin \"io.containerd.internal.v1.opt\"..." type=io.containerd.internal.v1
sandbox.go:131: time="2024-03-21T23:29:09.798248307Z" level=warning msg="failed to load plugin io.containerd.internal.v1.opt" error="mkdir /opt/containerd: permission denied"
sandbox.go:131: time="2024-03-21T23:29:09.798271441Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.blockfile\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:09.798357020Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.blockfile\"..." error="no scratch file generator: skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:09.798382007Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.devmapper\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:09.798404058Z" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.devmapper" error="devmapper not configured"
sandbox.go:131: time="2024-03-21T23:29:09.798422863Z" level=info msg=
|
Generate annotations:
frontend/dockerfile/dockerfile_mount_test.go#L132
=== RUN TestIntegration/TestMountInvalid/worker=containerd-rootless/frontend=builtin
=== PAUSE TestIntegration/TestMountInvalid/worker=containerd-rootless/frontend=builtin
=== CONT TestIntegration/TestMountInvalid/worker=containerd-rootless/frontend=builtin
dockerfile_mount_test.go:132:
Error Trace: /src/frontend/dockerfile/dockerfile_mount_test.go:132
/src/util/testutil/integration/run.go:91
/src/util/testutil/integration/run.go:205
Error: "failed to solve: dockerfile parse error on line 3: unknown flag: mont (did you mean mount?)" does not contain "unexpected key 'typ'"
Test: TestIntegration/TestMountInvalid/worker=containerd-rootless/frontend=builtin
sandbox.go:128: stderr: /usr/bin/sudo -u #1000 -i CONTAINERD_ROOTLESS_ROOTLESSKIT_STATE_DIR=/tmp/bktest_containerd1037799932/rootlesskit-containerd CONTAINERD_ROOTLESS_ROOTLESSKIT_NET=host CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=none CONTAINERD_ROOTLESS_ROOTLESSKIT_FLAGS=--mtu=0 containerd-rootless.sh -c /tmp/bktest_containerd1037799932/config.toml
sandbox.go:131: > StartCmd 2024-03-21 23:29:09.981476196 +0000 UTC m=+3.391590626 /usr/bin/sudo -u #1000 -i CONTAINERD_ROOTLESS_ROOTLESSKIT_STATE_DIR=/tmp/bktest_containerd1037799932/rootlesskit-containerd CONTAINERD_ROOTLESS_ROOTLESSKIT_NET=host CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=none CONTAINERD_ROOTLESS_ROOTLESSKIT_FLAGS=--mtu=0 containerd-rootless.sh -c /tmp/bktest_containerd1037799932/config.toml
sandbox.go:131: time="2024-03-21T23:29:09Z" level=warning msg="The host root filesystem is mounted as \"master:293\". Setting child propagation to \"rslave\" is not supported."
sandbox.go:131: time="2024-03-21T23:29:10Z" level=warning msg="containerd config version `1` has been deprecated and will be removed in containerd v2.0, please switch to version `2`, see https://github.com/containerd/containerd/blob/main/docs/PLUGINS.md#version-header"
sandbox.go:131: time="2024-03-21T23:29:10.044766916Z" level=info msg="starting containerd" revision=8c087663b0233f6e6e2f4515cee61d49f14746a8 version=v1.7.7
sandbox.go:131: time="2024-03-21T23:29:10.064110425Z" level=info msg="loading plugin \"io.containerd.event.v1.exchange\"..." type=io.containerd.event.v1
sandbox.go:131: time="2024-03-21T23:29:10.064148365Z" level=info msg="loading plugin \"io.containerd.internal.v1.opt\"..." type=io.containerd.internal.v1
sandbox.go:131: time="2024-03-21T23:29:10.064194080Z" level=warning msg="failed to load plugin io.containerd.internal.v1.opt" error="mkdir /opt/containerd: permission denied"
sandbox.go:131: time="2024-03-21T23:29:10.064217294Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.blockfile\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:10.064311539Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.blockfile\"..." error="no scratch file generator: skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:10.064330505Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.devmapper\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:10.064347166Z" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.devmapper" error="devmapper not configured"
sandbox.go:131: time="2024-03-21T23:29:10.064360381Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.native\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:10.064554464Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.overlayfs\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:10.064777250Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.aufs\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:10.065647781Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.aufs\"..." error="aufs is not supported (modprobe aufs failed: exit status 1 \"modprobe: c
|
Generate annotations:
frontend/dockerfile/dockerfile_mount_test.go#L132
=== RUN TestIntegration/TestMountInvalid/worker=containerd-rootless/frontend=client
=== PAUSE TestIntegration/TestMountInvalid/worker=containerd-rootless/frontend=client
=== CONT TestIntegration/TestMountInvalid/worker=containerd-rootless/frontend=client
dockerfile_mount_test.go:132:
Error Trace: /src/frontend/dockerfile/dockerfile_mount_test.go:132
/src/util/testutil/integration/run.go:91
/src/util/testutil/integration/run.go:205
Error: "failed to solve: dockerfile parse error on line 3: unknown flag: mont (did you mean mount?)" does not contain "unexpected key 'typ'"
Test: TestIntegration/TestMountInvalid/worker=containerd-rootless/frontend=client
sandbox.go:128: stdout: /usr/bin/sudo -u #1000 -i CONTAINERD_ROOTLESS_ROOTLESSKIT_STATE_DIR=/tmp/bktest_containerd3201662650/rootlesskit-containerd CONTAINERD_ROOTLESS_ROOTLESSKIT_NET=host CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=none CONTAINERD_ROOTLESS_ROOTLESSKIT_FLAGS=--mtu=0 containerd-rootless.sh -c /tmp/bktest_containerd3201662650/config.toml
sandbox.go:128: stderr: /usr/bin/sudo -u #1000 -i CONTAINERD_ROOTLESS_ROOTLESSKIT_STATE_DIR=/tmp/bktest_containerd3201662650/rootlesskit-containerd CONTAINERD_ROOTLESS_ROOTLESSKIT_NET=host CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=none CONTAINERD_ROOTLESS_ROOTLESSKIT_FLAGS=--mtu=0 containerd-rootless.sh -c /tmp/bktest_containerd3201662650/config.toml
sandbox.go:131: > StartCmd 2024-03-21 23:29:09.86970024 +0000 UTC m=+3.279814660 /usr/bin/sudo -u #1000 -i CONTAINERD_ROOTLESS_ROOTLESSKIT_STATE_DIR=/tmp/bktest_containerd3201662650/rootlesskit-containerd CONTAINERD_ROOTLESS_ROOTLESSKIT_NET=host CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=none CONTAINERD_ROOTLESS_ROOTLESSKIT_FLAGS=--mtu=0 containerd-rootless.sh -c /tmp/bktest_containerd3201662650/config.toml
sandbox.go:131: time="2024-03-21T23:29:09Z" level=warning msg="The host root filesystem is mounted as \"master:293\". Setting child propagation to \"rslave\" is not supported."
sandbox.go:131: time="2024-03-21T23:29:09Z" level=warning msg="containerd config version `1` has been deprecated and will be removed in containerd v2.0, please switch to version `2`, see https://github.com/containerd/containerd/blob/main/docs/PLUGINS.md#version-header"
sandbox.go:131: time="2024-03-21T23:29:09.923915249Z" level=info msg="starting containerd" revision=8c087663b0233f6e6e2f4515cee61d49f14746a8 version=v1.7.7
sandbox.go:131: time="2024-03-21T23:29:09.946960729Z" level=info msg="loading plugin \"io.containerd.event.v1.exchange\"..." type=io.containerd.event.v1
sandbox.go:131: time="2024-03-21T23:29:09.946994201Z" level=info msg="loading plugin \"io.containerd.internal.v1.opt\"..." type=io.containerd.internal.v1
sandbox.go:131: time="2024-03-21T23:29:09.947039786Z" level=warning msg="failed to load plugin io.containerd.internal.v1.opt" error="mkdir /opt/containerd: permission denied"
sandbox.go:131: time="2024-03-21T23:29:09.947056156Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.blockfile\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:09.947150462Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.blockfile\"..." error="no scratch file generator: skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:09.947170600Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.devmapper\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:09.947187161Z" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.devmapper" error="devmapper not configured"
sandbox.go:131: time="2024-03-21T23:29:09.947199293Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.native\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="2024-03-21T23:29:09.947308387Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.overlayfs\"..." type=io.containerd.snapshotter.v1
sandbox.go:131: time="
|
Generate annotations:
frontend/dockerfile/dockerfile_addchecksum_test.go#L93
=== RUN TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestMismatch
dockerfile_addchecksum_test.go:93:
Error Trace: /src/frontend/dockerfile/dockerfile_addchecksum_test.go:93
Error: An error is expected but got nil.
Test: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestMismatch
Messages: digest mismatch
--- FAIL: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestMismatch (0.02s)
|
Generate annotations:
frontend/dockerfile/dockerfile_addchecksum_test.go#L110
=== RUN TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithKnownButUnsupportedAlgoName
dockerfile_addchecksum_test.go:110:
Error Trace: /src/frontend/dockerfile/dockerfile_addchecksum_test.go:110
Error: An error is expected but got nil.
Test: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithKnownButUnsupportedAlgoName
Messages: unsupported digest algorithm
--- FAIL: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithKnownButUnsupportedAlgoName (0.02s)
|
Generate annotations:
frontend/dockerfile/dockerfile_addchecksum_test.go#L127
=== RUN TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithUnknownAlgoName
dockerfile_addchecksum_test.go:127:
Error Trace: /src/frontend/dockerfile/dockerfile_addchecksum_test.go:127
Error: An error is expected but got nil.
Test: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithUnknownAlgoName
Messages: unsupported digest algorithm
--- FAIL: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithUnknownAlgoName (0.02s)
|
Generate annotations:
frontend/dockerfile/dockerfile_addchecksum_test.go#L144
=== RUN TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithoutAlgoName
dockerfile_addchecksum_test.go:144:
Error Trace: /src/frontend/dockerfile/dockerfile_addchecksum_test.go:144
Error: An error is expected but got nil.
Test: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithoutAlgoName
Messages: invalid checksum digest format
--- FAIL: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/DigestWithoutAlgoName (0.02s)
|
Generate annotations:
frontend/dockerfile/dockerfile_addchecksum_test.go#L163
=== RUN TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/NonHTTPSource
dockerfile_addchecksum_test.go:163:
Error Trace: /src/frontend/dockerfile/dockerfile_addchecksum_test.go:163
Error: An error is expected but got nil.
Test: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/NonHTTPSource
Messages: checksum can't be specified for non-HTTP sources
--- FAIL: TestIntegration/TestAddChecksum/worker=containerd-rootless/frontend=builtin/NonHTTPSource (0.02s)
|
Test
Process completed with exit code 1.
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: codecov/codecov-action@v3, actions/github-script@v6, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Loading