You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should avoid using {!! te('key') !!} everywhere and instead always return an HtmlString. We should also always escape all parameters passed in the $replace argument (second argument of the get() method) instead of doing {!! te('key', ['a' => e($input)]) !!} everywhere.
The text was updated successfully, but these errors were encountered:
For the second feature request (i.e. escaping $replace), I don't think it's a good idea. Since we're only forwarding translations to Laravel's translation getter, I think it's better if we keep trans() and te() aligned.
As discussed, getEditor() does return an HtmlString. But, this method is only called when the editor is enabled. When the editor is disabled, getTranslation() is directly called and this method does not return an HtmlString. You did propose to build a blade component to fix this specific issue, but I do not remember exactly how this will resolve it.
We should avoid using
{!! te('key') !!}
everywhere and instead always return an HtmlString. We should also always escape all parameters passed in the$replace
argument (second argument of theget()
method) instead of doing{!! te('key', ['a' => e($input)]) !!}
everywhere.The text was updated successfully, but these errors were encountered: