Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate issues with v3.0.5 release, prepare v3.0.6 #217

Closed
joewiz opened this issue Nov 30, 2022 · 11 comments
Closed

Investigate issues with v3.0.5 release, prepare v3.0.6 #217

joewiz opened this issue Nov 30, 2022 · 11 comments
Labels

Comments

@joewiz
Copy link
Member

joewiz commented Nov 30, 2022

v3.0.5 was released but the pom.xml file still reads 3.0.5-SNAPSHOT, and release notes are missing.

We should investigate what happened with this release and then prepare a new version with release notes and an updated pom, etc.

@adamretter
Copy link
Member

adamretter commented Nov 30, 2022

@joewiz The pom.xml file should now be correct in master, I simply hadn't finished the process by time you wrote the issue ;-)

The release was cut from a hotfix branch that has its own pom.xml file which was already correct - https://github.com/eXist-db/monex/tree/hotfix-3.0.5

Regards the release notes in the xar-assembly.xml, I was not aware of those. Are they meant to be auto-generated? If not, we should probably document what the release process is for Monex in the README.md.
As otherwise a developer who is unaware of any manual steps that are needed needed (like myself), will see a Maven project and run the standard Maven commands to do a release, i.e. mvn release:prepare && mvn release:perform

@line-o
Copy link
Member

line-o commented Dec 1, 2022

The tests do not pass. There is one failing cypress test.
Also the changes were merged by the committer by the looks of things. That is alarming even if it is just a very small change.

@line-o line-o added the triage label Dec 1, 2022
@line-o
Copy link
Member

line-o commented Dec 1, 2022

Why was there a release from a hot fix branch in the first place?
Is this release compatible with older versions of exist, since this version already includes the update to slf4japi?

@line-o
Copy link
Member

line-o commented Dec 1, 2022

related issue eXist-db/exist#4622

@adamretter
Copy link
Member

The tests do not pass. There is one failing cypress test.

The tests were failing due to an unrelated reason to these changes. The reason that they failed is that there was a bad Docker image for the latest tag that was being downloaded. I fixed that by uploading the correct Docker image to Docker Hub.

@adamretter
Copy link
Member

Why was there a release from a hot fix branch in the first place?

That is the only way you can create a hotfix release after the main branch has moved on from the previous release tag!

Is this release compatible with older versions of exist, since this version already includes the update to slf4japi?

Yes. The hotfix release does not include the update to slf4japi - please check the commit history of the tag if you are uncertain about that.

@duncdrum
Copy link
Contributor

duncdrum commented Dec 1, 2022

The tests do not pass. There is one failing cypress test.

The tests were failing due to an unrelated reason to these changes. The reason that they failed is that there was a bad Docker image for the latest tag that was being downloaded. I fixed that by uploading the correct Docker image to Docker Hub.

How was that? The images are automatically updated from develop. How was the image bad? Could you just have triggered the deploy step on ci, or did you need to do something else ?

@adamretter
Copy link
Member

How was that?

@duncdrum I don't know how it got into the bad state

@line-o
Copy link
Member

line-o commented Dec 12, 2022

@adamretter will we know if it gets into a bad state again?

@duncdrum
Copy link
Contributor

@joewiz after the most recent merges, I think we are ready for 3.0.6 which should run on both 5.x and 6.x

@joewiz
Copy link
Member Author

joewiz commented Jan 7, 2023

Superseded by #210 and #230.

@joewiz joewiz closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants