Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building upon base layer #15

Open
grantmacken opened this issue Aug 2, 2018 · 4 comments
Open

Building upon base layer #15

grantmacken opened this issue Aug 2, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@grantmacken
Copy link
Contributor

grantmacken commented Aug 2, 2018

I want to argue the case, for keeping the base layer as simple as practicable and then layering use cases into tagged images.

Obviously, when it comes to docker images, size matters. Once you have a layer in place, it is easy to add/subtract stuff and give it a tag. You could say have a v3.4.1-teiPub tag with the eXist TEI Publisher env preinstalled.

The trick is deciding what should be in and what should be out of the base layer.
Please add suggestions, comments.

  • Out: /bin - reason: no shell
  • Out: /tests - reason: its all ready been tested
@adamretter
Copy link
Member

I agree that we can drop /bin and /tests

@adamretter adamretter added the enhancement New feature or request label Aug 2, 2018
@triage-new-issues triage-new-issues bot removed the triage label Aug 2, 2018
@duncdrum
Copy link
Contributor

duncdrum commented Aug 2, 2018

I actually think that /tests should be excluded by the minimal build flag if it isn't already. No objections to removing bin/

@duncdrum
Copy link
Contributor

duncdrum commented Aug 3, 2018

I also like the idea of use-case images, maybe we can discuss ideas in a video call.

@adamretter
Copy link
Member

I like the idea of use-case images, but not produced by us. We have limited resources. If the TEI-Publisher people want a TEI-Publisher docker image, we should give them the tools to create such a thing, but not do it for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants