Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Add test to Plugin Builder of _blank plugin is uploaded #5339

Open
Jimmi08 opened this issue Sep 14, 2024 · 3 comments
Open
Labels
type: bug A problem that should not be happening

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Sep 14, 2024

Motivation

When you delete _blank plugin, you can't use plugin builder - there is a fatal error in PHP 8.

Proposed Solution

Add check if needed plugin (files) are there and display error, don't continue.

Alternatives

.

Additional Context

No response

@Jimmi08 Jimmi08 added the type: enhancement An improvement or new feature request label Sep 14, 2024
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Sep 14, 2024

Just note:
it generated: protected $table = '';

  • table name is empty
  • I don't have time to look at it now.

@tgtje
Copy link
Contributor

tgtje commented Sep 14, 2024

@Jimmi08 just info
source? = e107_handlers/plugin_class.php line 1478
protected $core_plugins = array(
"_blank","admin_menu","banner","blogcalendar_menu",

notify or fileinspector being the generator?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Sep 14, 2024

@Jimmi08 just info source? = e107_handlers/plugin_class.php line 1478 protected $core_plugins = array( "_blank","admin_menu","banner","blogcalendar_menu",

notify or fileinspector being the generator?

When you delete blank plugin (because you don't want test/demo plugin) and you forgot about this, and then you want to use plugin builder, because fatal error in PHP 8 - something with arrays and missing keys.

There should be check if this plugin is mandatory for plugin builder.

@Moc Moc added type: bug A problem that should not be happening and removed type: enhancement An improvement or new feature request labels Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants