-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#51 free liquidity -- Draft PR #66
Conversation
Freezing this feature while a better SDK or an alternative solution is found.Accomplished in this work are predictable gas costs for market orders within the market module. A solution explored for mitigating the security vulnerability is adding a BaseApp custom panic handler, combined with the handler having access to the transaction gas meter for charging a gas fee which sadly it does not. As a future consideration, we could open an issue with the Cosmos SDK team to add gas meter access to panic-handlers applicable to this and other business functionality. |
There is a completed Cosmos SDK PR that meets the needs of this functionality, and it was stalled because of a lack of an accompanied ADR. We could pick up the pieces for this and contribute the ADR and facilitate the re-opening of the stalled PR to complete this add gas refund handler to refund the remaining gas fee at the end of transaction #8993. |
Please note, changesets from previous open PRs have crept in.
A. Draft PR for soliciting feedback on completed 1..4 issue items.
B. This PR does not address issue section:
Additional considerations
.Suggestions below
Half baked ideas
C. Three Market parameters have been added