Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using keyring-backend=os leads to a high number of Keychain passwords prompts #121

Open
mdyring opened this issue Aug 27, 2021 · 4 comments
Assignees

Comments

@mdyring
Copy link
Contributor

mdyring commented Aug 27, 2021

Describe the bug
It seems emd does something differently from gaiad when doing keys list.

On gaiad it will ask for the Keychain (for MacOS) password once. With emd it prompts for the password for each key.

How to reproduce

emd keys add key1
emd keys add key2
emd keys add key3
emd keys add key4
emd keys list

Observe: you will need to enter Keychain password 4 times before the list is shown.

Expected behavior
Keychain password should only be entered once to list all the keys.

Additional context
Maybe emd tries to read secret data when listing keys? (causing the Keychain prompt)

@mdyring
Copy link
Contributor Author

mdyring commented Aug 27, 2021

osmosisd seems to exhibit same behaviour as emd. Maybe gaiad is doing something "clever"?

@dualsystems
Copy link

If use keyring-backend file on linux system prompts one time.

@blewater
Copy link
Contributor

Couldn't replicate this issue on Catalina.

In the following steps, I was prompted for the password once

emd config keyring-backend os
emd config keyring-backend
os
emd keys add key1
emd keys add key2
emd keys add key3
emd keys add key4
emd keys list | jq
[
  {
    "name": "key1",
    "type": "local",
    "address": "emoney13mlhdy23h952suhhp8dthwu7ucvalr5lxjndsr",
    "pubkey": "emoneypub1addwnpepqf9zcq0vwrgmekxqd7c5dn8q2gnzzwv64qtgcharqcg03x6llm63z69yl7r"
  },
...

@blewater
Copy link
Contributor

os points to the macOS keychain. These macOS instructions may offer insight into the stored passwords https://support.apple.com/en-gb/guide/keychain-access/kyca1085/11.0/mac/11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@blewater @mdyring and others