From b9f046fb286a10afb9f465735a8bc3441d96489e Mon Sep 17 00:00:00 2001
From: Benedikt Kuehne <bennimail.4spam@gmail.com>
Date: Fri, 17 Nov 2023 12:48:29 +0000
Subject: [PATCH] linter fix

---
 embark/templates/user/timezone.html | 2 +-
 embark/uploader/models.py           | 5 ++---
 embark/users/urls.py                | 4 ++--
 embark/users/views.py               | 7 ++++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/embark/templates/user/timezone.html b/embark/templates/user/timezone.html
index aeeb96d5..8b3a8a72 100644
--- a/embark/templates/user/timezone.html
+++ b/embark/templates/user/timezone.html
@@ -1,6 +1,6 @@
 {% load tz %}
 {% get_current_timezone as TIME_ZONE %}
-<form action="{% url 'embark-acc-timezone' %}" method="POST">
+<form action="{% url 'embark-acc-timezone' %}" method="post">
     {% csrf_token %}
     <label for="timezone">Time zone:</label>
     <select name="timezone">
diff --git a/embark/uploader/models.py b/embark/uploader/models.py
index 35a62592..4e1bb8dc 100644
--- a/embark/uploader/models.py
+++ b/embark/uploader/models.py
@@ -383,7 +383,7 @@ def get_flags(self):
         # running emba
         logger.info("final emba parameters %s", command)
         return command
-    
+
     def do_archive(self):
         """
         cleans up the firmwareanalysis log_dir up to a point where it's minimal
@@ -391,7 +391,6 @@ def do_archive(self):
         """
         logger.info("Archiving %s", self.id)
         logger.debug("Function not implemented yet. %s stays the same", self.id)
-        pass
 
 
 @receiver(pre_delete, sender=FirmwareAnalysis)
@@ -412,7 +411,7 @@ def delete_analysis_pre_delete(sender, instance, **kwargs):
         else:
             pass
     except builtins.Exception as _error:
-        logger.error("Error durring delete of: %s - %s", str(sender),_error)
+        logger.error("Error durring delete of: %s - %s", str(sender), _error)
 
 
 class ResourceTimestamp(models.Model):
diff --git a/embark/users/urls.py b/embark/users/urls.py
index 3339e7d3..f41e3d9c 100644
--- a/embark/users/urls.py
+++ b/embark/users/urls.py
@@ -6,12 +6,12 @@
 
 urlpatterns = [
     path(settings.LOGIN_URL, views.embark_login, name='embark-login'),
-    path('user/',views.user_main, name='embark-user-main'),
+    path('user/', views.user_main, name='embark-user-main'),
     path('register/', views.register, name='embark-register'),
     path('logout/', views.embark_logout, name='embark-logout'),
     path('user/password_change/', views.password_change, name='embark-password-change'),
     path('user/acc_delete/', views.acc_delete, name='embark-acc-delete'),
-    path('user/set_timezone/', views.set_timezone, name='embark-acc-timezone'),\
+    path('user/set_timezone/', views.set_timezone, name='embark-acc-timezone'),
     # TODO account menu path('my-account/', views., name='embark-), for admin options etc
     path('log/<int:log_type>/<int:lines>/', views.get_log, name='log'),
 ]
diff --git a/embark/users/views.py b/embark/users/views.py
index 07307085..17112f02 100644
--- a/embark/users/views.py
+++ b/embark/users/views.py
@@ -4,7 +4,6 @@
 from datetime import datetime
 
 from django.contrib.auth.decorators import login_required
-from django.http import HttpResponseRedirect
 from django.shortcuts import render, redirect
 from django.views.decorators.csrf import csrf_exempt
 from django.views.decorators.http import require_http_methods
@@ -17,12 +16,13 @@
 
 logger = logging.getLogger(__name__)
 
+
 @require_http_methods(["GET"])
 def user_main(request):
-    logger.debug("Account settings for %s",request.user)
-    
+    logger.debug("Account settings for %s", request.user)
     return render(request, 'user/index.html', {"timezones": settings.TIMEZONES})
 
+
 @csrf_exempt
 @require_http_methods(["GET", "POST"])
 def register(request):
@@ -214,6 +214,7 @@ def get_log(request, log_type, lines):      # FIXME update or remove
     except IOError:
         return render(request, 'user/log.html', {'header': 'Error', 'log': file_path + ' not found!', 'username': request.user.username})
 
+
 @require_http_methods(["POST"])
 @login_required(login_url='/' + settings.LOGIN_URL)
 def set_timezone(request):