Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create support for Apache Http Client #18

Open
dzieciou opened this issue Oct 13, 2017 · 3 comments
Open

Create support for Apache Http Client #18

dzieciou opened this issue Oct 13, 2017 · 3 comments

Comments

@dzieciou
Copy link
Owner

In the end we would have three modules

  • curl-logger-core: containing CurlCommand
  • curl-logger-apache: containing implementation of Http2Curl specification for HttpRequest
  • curl-logger-rest-assured: containing implementation of Http2Curl specific for RestAssuredSpecification
dzieciou added a commit that referenced this issue Oct 16, 2017
@francislainy
Copy link

francislainy commented Sep 21, 2020

Hi @dzieciou , I love your library. Thanks so much, it's been a really time saver when debugging issues and I've recommended it to my colleagues too. I've now been looking for Http support and found this issue here and it would be really great if this could be done too please, as I think it would then allows us to use to debug Pact tests that are usually written as per the below.

@TestTemplate
@ExtendWith(PactVerificationInvocationContextProvider.class)
void pactTestTemplate(PactVerificationContext context, HttpRequest request) {
    request.addHeader("Authorization", AUTHORIZATION_TOKEN);
    context.verifyInteraction();
}

Ps: At the moment, I've been manually doing this as per https://stackoverflow.com/questions/64008576/how-to-turn-pact-interactions-into-curl/64008577

Thanks once again.

@dzieciou
Copy link
Owner Author

dzieciou commented Sep 22, 2020

@francislainy Thank you for reminding me about this issue.

I once started to work on supporting Apache HTTP Client but the change requires significant refactoring effort and I have less time to maintain this project recently. So I cannot promise implementing this feature will happen soon. Definitely not within next month.

However, I can start collecting test cases like your to drive this effort.

@francislainy
Copy link

Sure, understand that and appreciate the time put into offering this great and free library back to the community. Whenever you can please and that should be good enough. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants