-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SAPBW
source
#1066
Comments
remove |
Seems like this So I guess this function is confusing for 3 reasons:
So it should probably be split into 2 functions or just native dataframe functions used (filtering a df and renaming columns are done with a single line of code in core pandas, so it's likely wrappers are not needed). |
Check if
_apply_user_mapping()
is needed and if possible replace it withdf.rename(columns=mapping_dict)
.api_connection()
should be refactored intoto_records()
or just included as part ofto_df()
add unit tests
#1053 (comment)
The text was updated successfully, but these errors were encountered: