Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery and Mediatool - remove api_connection() method #1049

Open
mgardzinski opened this issue Sep 24, 2024 · 0 comments
Open

BigQuery and Mediatool - remove api_connection() method #1049

mgardzinski opened this issue Sep 24, 2024 · 0 comments
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request

Comments

@mgardzinski
Copy link

mgardzinski commented Sep 24, 2024 •
edited
Loading

The current method api_connection() suggests that it creates and returns an API connection, which is misleading since it actually downloads data without returning anything. This can be confusing for users.

Sources:
Bigquery and Mediatool

Suggested changes:

  • Rename api_connection() to to_records()
    or
  • Move the logic from api_connection() directly into to_df() to simplify the code.
@mgardzinski mgardzinski added the 2.0 backlog Backlog for logic issues in connectors after migration label Sep 24, 2024
@mgardzinski mgardzinski mentioned this issue Sep 24, 2024
Merged
5 tasks
@mgardzinski mgardzinski changed the title Clarify functionality of api_connection() method Clarify functionality of api_connection() method in Bigquery Source Sep 24, 2024
@mgardzinski mgardzinski mentioned this issue Sep 25, 2024
Merged
5 tasks
@mgardzinski mgardzinski changed the title Clarify functionality of api_connection() method in Bigquery Source Clarify functionality of api_connection() method Sep 25, 2024
@trymzet trymzet changed the title Clarify functionality of api_connection() method Refactor or remove api_connection() method Sep 26, 2024
@trymzet trymzet changed the title Refactor or remove api_connection() method Eemove api_connection() method Sep 30, 2024
@trymzet trymzet added enhancement New feature or request 2.0 viadot 2.0 labels Sep 30, 2024
@trymzet trymzet changed the title Eemove api_connection() method Remove api_connection() method Sep 30, 2024
@trymzet trymzet changed the title Remove api_connection() method BigQuery and Mediatool - remove api_connection() method Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trymzet @mgardzinski