Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery - rename gbd() to _get_google_bigquery_data() #1048

Open
mgardzinski opened this issue Sep 24, 2024 · 0 comments
Open

BigQuery - rename gbd() to _get_google_bigquery_data() #1048

mgardzinski opened this issue Sep 24, 2024 · 0 comments
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request good first issue Good for newcomers

Comments

@mgardzinski
Copy link

Coments from @trymzet
Can you pls use a full name? It's unclear what gbd is an abbreviation of.

Suggested change

def _get_google_bigquery_data(self, query: str) -> pd.DataFrame:
@mgardzinski mgardzinski added the 2.0 backlog Backlog for logic issues in connectors after migration label Sep 24, 2024
@mgardzinski mgardzinski mentioned this issue Sep 24, 2024
Merged
5 tasks
@mgardzinski mgardzinski changed the title Use full function name for clarity Use full function name for clarity in Bigquery Source Sep 24, 2024
@trymzet trymzet changed the title Use full function name for clarity in Bigquery Source BigQuery - rename gbd() to _get_google_bigquery_data() Sep 30, 2024
@trymzet trymzet added enhancement New feature or request good first issue Good for newcomers 2.0 viadot 2.0 labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trymzet @mgardzinski