From 1af609d9a7817000ab69f6929fc8cbd760e3daac Mon Sep 17 00:00:00 2001 From: Dyon Ng Date: Mon, 17 Apr 2023 14:20:03 -0400 Subject: [PATCH] version bump: 0.8.16; removed premature cleanup from generate systems; --- CHANGELOG.md | 6 ++++++ .../ApplySystems/Transform/TweenSplineMovementSystem.cs | 2 +- .../Systems/Control/Jobless/JoblessTweenGenerateSystem.cs | 1 - Runtime/Tweens/Systems/Control/TweenGenerateSystem.cs | 1 - package.json | 2 +- 5 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2f648fb..814a4bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## [0.8.16] 2023.04.17 + +### Fixed + +- Spline Movement wasn't working due to premature cleanup + ## [0.8.15] 2023.04.03 ### Fixed diff --git a/Runtime/Tweens/Systems/ApplySystems/Transform/TweenSplineMovementSystem.cs b/Runtime/Tweens/Systems/ApplySystems/Transform/TweenSplineMovementSystem.cs index fecae0c..9199595 100644 --- a/Runtime/Tweens/Systems/ApplySystems/Transform/TweenSplineMovementSystem.cs +++ b/Runtime/Tweens/Systems/ApplySystems/Transform/TweenSplineMovementSystem.cs @@ -32,7 +32,7 @@ protected override void OnUpdate() { var forward = math.normalize(tweenInfo.SplineTweenInfo.Spline.EvaluateTangent(splinePosition)); var up = tweenInfo.SplineTweenInfo.Spline.EvaluateUpVector(splinePosition); - localTransformRef.ValueRW.Rotation = quaternion.LookRotation(forward, up); + localTransformRef.ValueRW.Rotation = math.normalize(quaternion.LookRotation(forward, up)); } } } diff --git a/Runtime/Tweens/Systems/Control/Jobless/JoblessTweenGenerateSystem.cs b/Runtime/Tweens/Systems/Control/Jobless/JoblessTweenGenerateSystem.cs index 7db3b8e..53f3e62 100644 --- a/Runtime/Tweens/Systems/Control/Jobless/JoblessTweenGenerateSystem.cs +++ b/Runtime/Tweens/Systems/Control/Jobless/JoblessTweenGenerateSystem.cs @@ -53,7 +53,6 @@ protected override void OnUpdate() info.SetTweenId(tween.Id); info.SetTweenInfo(commandRef.ValueRO.GetTweenStart(), commandRef.ValueRO.GetTweenEnd()); - commandRef.ValueRW.Cleanup(); ecb.AddComponent(entity, info); ecb.RemoveComponent(entity); } diff --git a/Runtime/Tweens/Systems/Control/TweenGenerateSystem.cs b/Runtime/Tweens/Systems/Control/TweenGenerateSystem.cs index f97a8b9..aa12d6a 100644 --- a/Runtime/Tweens/Systems/Control/TweenGenerateSystem.cs +++ b/Runtime/Tweens/Systems/Control/TweenGenerateSystem.cs @@ -103,7 +103,6 @@ public void Execute(in ArchetypeChunk chunk, int chunkIndex, bool useEnabledMask TTweenInfo info = default; info.SetTweenId(tween.Id); info.SetTweenInfo(command.GetTweenStart(), command.GetTweenEnd()); - command.Cleanup(); ParallelWriter.AddComponent(chunkIndex, entity, info); ParallelWriter.RemoveComponent(chunkIndex, entity); } diff --git a/package.json b/package.json index 9a5ff9b..6eee00a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "com.dyonng.dotstween", - "version": "0.8.15", + "version": "0.8.16", "displayName": "DOTS Tween", "description": "Tween library for Unity ECS/DOTS.", "unity": "2022.2",