Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup script): gas price set for rollapp in scripts/ibc/setup_ibc.sh #164

Closed
wants to merge 2 commits into from

Conversation

srene
Copy link
Contributor

@srene srene commented Apr 18, 2024

Description


Closes #163

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

mtsitrin
mtsitrin previously approved these changes Apr 19, 2024
@omritoptix
Copy link
Contributor

@srene does the rest of the txs in the readme works ? i.e they don't also need to be added with gas-prices? I see you only changed the ibc tx .

@omritoptix omritoptix changed the title fix: gas price set for rollapp in scripts/ibc/setup_ibc.sh fix(setup script): gas price set for rollapp in scripts/ibc/setup_ibc.sh Apr 19, 2024
@srene
Copy link
Contributor Author

srene commented Apr 19, 2024

@srene does the rest of the txs in the readme works ? i.e they don't also need to be added with gas-prices? I see you only changed the ibc tx .

i didnt see the new script. i added it in the trigger_rollapp_genesis_event.sh as well.

@omritoptix
Copy link
Contributor

@srene merge conflicts

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label May 21, 2024
@github-actions github-actions bot closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update scripts/ibc/setup_ibc.sh to set gas-prices for RA txs
3 participants