Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up manager start method #1148

Closed
omritoptix opened this issue Oct 20, 2024 · 1 comment · Fixed by #1183 · May be fixed by #1154
Closed

Clean up manager start method #1148

omritoptix opened this issue Oct 20, 2024 · 1 comment · Fixed by #1183 · May be fixed by #1154
Assignees
@mtsitrin

Comments

@omritoptix
Copy link
Contributor

currently the method contains a lot of logic which can be separated to it's own methods (such as full node mode and sequencer mode etc).
@mtsitrin
Copy link
Contributor

it's related to #1008 . i've started a refactor already

@mtsitrin mtsitrin mentioned this issue Oct 21, 2024
Draft
@mtsitrin mtsitrin linked a pull request Oct 21, 2024 that will close this issue
feat(block manager): rotation graceful role rotation #1154
Draft
@omritoptix omritoptix linked a pull request Oct 30, 2024 that will close this issue
refactor(manager): cleanup proposer, full node and rotation flows #1183
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtsitrin mtsitrin

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@omritoptix @mtsitrin