Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Incomplete validation of the GenesisState of the Rollapp module #1586

Open
danwt opened this issue Nov 30, 2024 · 1 comment · May be fixed by #1657
Open

Minor: Incomplete validation of the GenesisState of the Rollapp module #1586

danwt opened this issue Nov 30, 2024 · 1 comment · May be fixed by #1657
Assignees
@NagaTulasi
Labels
good first issue Good for newcomers

Comments

@danwt
Copy link
Contributor

danwt commented Nov 30, 2024

In x/rollapp/genesis.go:25-90, the Validate method of the GenesisState does not perform validations for the LivenessEvents, RegisteredDenoms, and SequencerHeightPairs slices.
These slices are not checked for duplicate entries or for ensuring that their data is correctly constructed.
This omission can result in invalid or inconsistent state data being accepted during genesis initialization.
Recommendation
We recommend enhancing the Validate method to include comprehensive checks for the aforementioned slices.
@mtsitrin mtsitrin added the good first issue Good for newcomers label Dec 10, 2024
@NagaTulasi
Copy link

Hi @mtsitrin, Can I work on this?

@NagaTulasi NagaTulasi linked a pull request Dec 16, 2024 that will close this issue
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NagaTulasi NagaTulasi

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing validations in x/rollapp/types/genesis.go NagaTulasi/dymension
3 participants
@danwt @NagaTulasi @mtsitrin