Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Incomplete validation for MsgRollappFraudProposal #1587

Closed
danwt opened this issue Nov 30, 2024 · 1 comment
Closed

Minor: Incomplete validation for MsgRollappFraudProposal #1587

danwt opened this issue Nov 30, 2024 · 1 comment

Comments

@danwt
Copy link
Contributor

danwt commented Nov 30, 2024

Severity: Minor
In x/rollapp/types/message_fraud_proposal.go:14-32, the ValidateBasic method of the MsgRollappFraudProposal is incomplete. It does not validate fields such
24
DRAFT – NOT INTENDED TO BE SHARED
as RollappId, RollappRevision, FraudHeight, and PunishSequencerAddress to ensure they are correctly set and valid.
Without these validations, an invalid fraud proposal could be accepted for voting, run the full proposal lifecycle, only to fail during execution. This creates inefficiencies and risks undermining the governance process.
Recommendation
We recommend enhancing the Validate method to include comprehensive checks for the MsgRollappFraudProposal.

Same probably goes for slash proposal

@mtsitrin
Copy link
Contributor

mtsitrin commented Dec 4, 2024

dup of #1558

@mtsitrin mtsitrin closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants