Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readfile() for serving protected uploads #26

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Use readfile() for serving protected uploads #26

merged 6 commits into from
Jun 28, 2024

Commits on Jun 28, 2024

  1. Use readfile() for serving protected uploads 

    I suspect that one performance problem we have stems from loading
binary files into memory, and then using `echo()` to send them to
the client.

This switches off output buffering and uses `readfile()`.
    @leedxw @snim2
    leedxw authored and snim2 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    716e4a0 View commit details
    Browse the repository at this point in the history

  2. Disable output buffering in FastCGI / nginx 

    This header, if recieved by nginx, applies the following:

```
gzip off;
fastcgi_buffering off;
```

(The header is not passed to the client.)
    @leedxw @snim2
    leedxw authored and snim2 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f768e43 View commit details
    Browse the repository at this point in the history

  3. Update readme.txt changelog 

    https://wordpress.org/plugins/readme.txt
https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/
    @leedxw @snim2
    leedxw authored and snim2 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5664364 View commit details
    Browse the repository at this point in the history

  4. Range: should not be attempted for protected files

    @leedxw @snim2
    leedxw authored and snim2 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    35158eb View commit details
    Browse the repository at this point in the history

  5. Bump version to 4.3.0

    @snim2
    snim2 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    960ab22 View commit details
    Browse the repository at this point in the history

  6. Delete unused readme.txt 

    This repository has two readme files, this is the one
that is not displayed in GitHub. The information in
the files is duplicated so we can just remove this.
    @snim2
    snim2 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f52d008 View commit details
    Browse the repository at this point in the history