Optimise the rebuild further for the legacy data structure

dvdoug · Sep 15, 2019 · 30aaef1 · 30aaef1
1 parent 660a027
commit 30aaef1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/VolumePacker.php b/src/VolumePacker.php
@@ -381,8 +381,9 @@ protected function checkDimensionalConstraints(Item $itemToPack)
      */
     protected function rebuildItemList()
     {
-        $this->items = ItemList::fromArray(array_merge($this->skippedItems, iterator_to_array($this->items)));
-        $this->skippedItems = [];
+        while(count($this->skippedItems)) {
+            $this->items->insert(array_pop($this->skippedItems));
+        }
     }
 
     /**