-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 5 compatibility #13
Comments
I believe there are some code using Rails 3 features so that's why I added the specification. I haven't tried it out under rails 5. If you want clone and override the version requirement, I'm curious if a) tests all pass under rails 5 (they probably should because I don't think I'm testing anything specifically railsy); and b) if there are any actual failures when running under rails 5. Please feel free to create a PR with new tests / fixes or at least create issues if something breaks under rails 5 and then we can see about changing the requirements! |
It seems rails 5.1 removed alias_method_chain, which is being used here: compendium/config/initializers/rails/active_record/connection_adapters/quoting.rb Line 13 in 547f890
Would it be possible to have a conditional use of this method? Great gem by the way! |
@cimtico yeah, I'm going to drop support for Ruby < 2.2 so relying on Additionally, if anyone wants to make PRs for Rails 4/5 support I'd appreciate that. |
The version on RubyGems seems to be compatible with Rails 5, however the master branch of the repo specifies
< 4
.Is there a reason for this? Bundler has installed
1.1.3.4
in my Rails 5 app, which doesn't seem to have thetable
report DSL.The text was updated successfully, but these errors were encountered: