New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra or missing field in Furnishing type #14

Open

Victorsitou opened this issue May 25, 2023 · 1 comment

Contributor

Victorsitou commented May 25, 2023

Furnishing.originalId is only available in one Furnishing object, but I'm not sure if it's an extra field, or it's missing in the other objects.

genshin-data/src/types/furnishing.ts

Lines 14 to 17 in 088764d

    
           export interface Furnishing { 
        
             _id: number; 
        
             id: string; 
        
             originalId: number;

The text was updated successfully, but these errors were encountered:

Owner

dvaJi commented Jul 5, 2023

You're right, Furnishing.originalId doesn't exist. We should remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment