Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add CP Setting for SIH CloudFront Dist #8

Open
andrewmenich opened this issue Mar 20, 2020 · 1 comment
Open

[Enhancement] Add CP Setting for SIH CloudFront Dist #8

andrewmenich opened this issue Mar 20, 2020 · 1 comment

Comments

@andrewmenich
Copy link
Contributor

The current setup requires putting the Serverless Image Handler CloudFront Distribution URL in asset volume (I feel like perhaps I'm missing something?)This means that anything not routed through this plugin (e.g. images inserted via Redactor, PDFs, etc) would fail. It seems the escape hatch was meant to be the SIH Settings toggle field, but since the volume URL is the SIH distribution, that wouldn't work anyway.

My proposal is to have the plugin create a setting in the CP that accepts the SIH CloudFront distribution URL. This would better separate the SIH functionality from the asset volume. If the getImgUrl function is called in the template, it utilizes the URL defined in the setting rather than the volume url. This would allow assets not routed through the plugin to be fetched as normal via a regular CloudFront distribution.

Happy to submit a PR with these changes if you're open to it.

@KevinBeckers
Copy link
Collaborator

Andrew, thanks for the proposal. I am happy to include your PR, the plugin is indeed missing some basis features. I would like to expand the plugin, but this is on the bottom of my list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants