Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting efm-langserver as alternative to archived null-ls #5

Open
ModProg opened this issue Nov 28, 2023 · 3 comments
Open

Comments

@ModProg
Copy link

ModProg commented Nov 28, 2023

This would be cross-editor compatible and even be a preliminary solution for #1 with https://marketplace.visualstudio.com/items?itemName=Matts966.efm-langserver-vscode.

null-ls appears to be discontinued

@ModProg
Copy link
Author

ModProg commented Nov 28, 2023

This "support" would be similar to null-ls by just providing a config file.

@dustinblackman dustinblackman changed the title Consider supporting emf-langserver as alternative to archived null-ls Consider supporting efm-langserver as alternative to archived null-ls Nov 28, 2023
@ModProg
Copy link
Author

ModProg commented Nov 28, 2023

languages:
  rust:
    - lint-formats: ["%l,%c,%e,%k,%m"]
      lint-stdin: false
      lint-severity: 2
      lint-ignore-exit-code: true
      lint-command: |
        languagetool-code-comments check -f ${INPUT} -l en-US | jq -r '.[] | [.moreContext.line_number, .moreContext.line_offset + 1, .moreContext.line_number, .moreContext.line_offset + .context.length + 1, "\(.message) Try: \(.replacements | map(.value) | join(", "))"] | join(",")"'

This is diagnostics working, I might look at code actions as well at some point.

@dustinblackman
Copy link
Owner

Amazing! Great work!

I may try to chip in if I can allocate time, otherwise I'll gladly accept a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants