Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI uses nightly version which disallowed the toolchain file to use its own version #116

Open
Daksh14 opened this issue Jun 4, 2024 · 1 comment
Labels
fix:bug Something isn't working

Comments

@Daksh14
Copy link
Contributor

Daksh14 commented Jun 4, 2024

either change CI nightly version or use same versions in toolchain file and CI

@Daksh14 Daksh14 added the fix:bug Something isn't working label Jun 4, 2024
@ZER0
Copy link
Contributor

ZER0 commented Jun 4, 2024

The CI should automatically pick the rust-toolchain file if present, as we do in other projects (see Rusk for example), we shouldn't have anything hard-coded; so that the only "source of truth" is the rust-toolchain file. You can also thinking of change it in its toml version, that gives us more flexibility (when introduced the first time the toolchain file, the toml wasn't supported yet, but now it's been a while): https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants