Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-wallet: Improve Migration Functionality #3268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

web-wallet: Improve Migration Functionality #3268

wants to merge 1 commit into from
+82 −69

Conversation

nortonandreev
Copy link
Contributor

Resolves #3267

Follow the linked issue for details on the changes delivered.

@nortonandreev nortonandreev self-assigned this Dec 21, 2024
HDauven
HDauven approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The idea to throw an error when the Reown project ID is missing makes sense to me if migrate is enabled.

I noticed that on migration it can take a while before the wallet syncs again. If possible, it would probably be nice to trigger a sync call to the Dusk chain. This will probably take away some questions/fear from users when the funds do not show up.

@nortonandreev
Copy link
Contributor Author

nortonandreev commented Dec 22, 2024 •
edited
Loading

The idea to throw an error when the Reown project ID is missing makes sense to me if migrate is enabled.

This happens by default, as the Reown is initialized no matter if migrate is enabled or not – I don't think this is optimal, but, with the way the code is currently structured, it is what it is. So, if a project ID is missing, an error will be thrown from Reown initialization (however, the app won't break).

If I was to throw an error explicitly, then the application wouldn't load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

@kieranhall kieranhall Awaiting requested review from kieranhall

Assignees

@nortonandreev nortonandreev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web-wallet: Improve Migration Functionality
2 participants
@nortonandreev @HDauven