Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Improve Migration Functionality #3267

Open
nortonandreev opened this issue Dec 21, 2024 · 0 comments · May be fixed by #3268
Open

web-wallet: Improve Migration Functionality #3267

nortonandreev opened this issue Dec 21, 2024 · 0 comments · May be fixed by #3268
Assignees
Labels
module:web-wallet Issues related to web-wallet module type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@nortonandreev
Copy link
Contributor

nortonandreev commented Dec 21, 2024

Description

The current Migration functionality in the Web Wallet requires improvements to align with best practices, enhance user experience, and ensure consistency across components. This issue outlines several tasks to achieve these goals.

Tasks

  1. Remove metadata:

    • metadata is currently used for analytics purposes, but analytics have been disabled.
  2. Add ENV Variable for Reown Project ID:

    • Replace the hardcoded Reown Project ID with an environment variable for improved configurability and security.
  3. Add Labels to the Stepper:

    • Include the following labels to the Stepper component for better clarity:
      • "Approve"
      • "Migrate"
      • "Done"
  4. Align Migrate Flow Layout:

    • The current Migrate flow uses a custom layout instead of the standardized Wizard used in other flows. Update the layout to ensure a consistent look and feel across all flows.
  5. Update Approval Success Copy:

    • Replace the existing approval success message ("Migration Approved") with a less confusing message. Suggested copy:
      • "Approval successful! You may now proceed with the migration."
  6. Remove migrationInProgress Flag:

  7. Replace Migration Requirements Details with the Banner Component:

    • Use the Banner component to display migration requirements, ensuring a consistent and visually appealing presentation.

Expected Outcome

  • The Migration functionality is more user-friendly and consistent with other parts of the application.
  • Codebase is simplified by removing unnecessary metadata, unused flags, and hardcoded values.
  • Users are provided with clearer guidance and improved overall experience during the migration process.
  • Migration requirements are displayed in a standardized format using the Banner component.

Additional Context

These changes are intended to streamline the Migration process and ensure the UI adheres to design and UX standards.

@nortonandreev nortonandreev self-assigned this Dec 21, 2024
@nortonandreev nortonandreev added type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) module:web-wallet Issues related to web-wallet module labels Dec 21, 2024
@nortonandreev nortonandreev changed the title web-wallet: Enhance Migration flow web-wallet: Improve Migration Functionality Dec 21, 2024
nortonandreev added a commit that referenced this issue Dec 21, 2024
nortonandreev added a commit that referenced this issue Dec 21, 2024
nortonandreev added a commit that referenced this issue Dec 21, 2024
@nortonandreev nortonandreev linked a pull request Dec 21, 2024 that will close this issue
nortonandreev added a commit that referenced this issue Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:web-wallet Issues related to web-wallet module type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant