-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web-wallet: Align gas limit defaults with Rusk wallet #3178
Labels
module:web-wallet
Issues related to web-wallet module
Comments
ascartabelli
added a commit
that referenced
this issue
Dec 16, 2024
- Add button to reset gas settings to their defaults - Fix dark mode button not being in sync with the stored value - Fix `BigIntInput` value not being reactive Resolves #3178
ascartabelli
added a commit
that referenced
this issue
Dec 16, 2024
- Add button to reset gas settings to their defaults - Fix dark mode button not being in sync with the stored value - Fix `BigIntInput` properties not being reactive Resolves #3178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently the Web wallet sets a very high gas limit for any transaction of 2.9 DUSK. In the past, when staking operations were quite expensive, these numbers made sense. But since cost were dramatically reduced, and we got more data on the cost of Phoenix and Moonlight transactions, we should lower the default to a more appropriate value.
Why should we do this? Because it will reduce the minimal balance users need and if a transaction fails they will lose less funds, as all failed transactions incur the full gas limit provided.
Possible solution design or implementation
Either align the gas limit defaults to what is being used in Rusk wallet: https://github.com/dusk-network/rusk/blob/master/rusk-wallet/src/gas.rs#L14L27
Or set a safe default, like 50M LUX.
The text was updated successfully, but these errors were encountered: