Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rusk-wallet: Ask user to confirm if they send to their own address #2959

Open
HDauven opened this issue Nov 13, 2024 · 0 comments · May be fixed by #3049
Open

rusk-wallet: Ask user to confirm if they send to their own address #2959

HDauven opened this issue Nov 13, 2024 · 0 comments · May be fixed by #3049
Assignees
Labels
module:rusk-wallet Issues related to rusk wallet type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@HDauven
Copy link
Member

HDauven commented Nov 13, 2024

Summary

It is possible for users to send DUSK to their own address. For certain use cases, like merging notes and posting metadata on-chain through a memo, this can be valid to do. If user's do send funds to themselves without this as explicit intent however, they will just be deducted the gas fee. It would therefor be helpful to warn the user if they're sending funds to their own address.

Possible solution design or implementation

We can take multiple approaches, but the simplest would be to check whether the sender and receiver are the same in interactive mode, and prompting the user to confirm if this is what they intended to do.

@HDauven HDauven added type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) module:rusk-wallet Issues related to rusk wallet labels Nov 13, 2024
@HDauven HDauven assigned Daksh14 and unassigned welf Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:rusk-wallet Issues related to rusk wallet type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants