Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disable_winning_att_check #2152

Closed
fed-franz opened this issue Aug 19, 2024 · 0 comments · Fixed by #2167
Closed

Remove disable_winning_att_check #2152

fed-franz opened this issue Aug 19, 2024 · 0 comments · Fixed by #2167
Assignees
@fed-franz
Labels
module:node Issues related to node module

Comments

@fed-franz
Copy link
Contributor

Summary

In verify_block_header, the parameter disable_winning_att_check is only used as true, and can be removed
@fed-franz fed-franz added the module:node Issues related to node module label Aug 19, 2024
@fed-franz fed-franz added this to Audits Aug 19, 2024
@fed-franz fed-franz moved this to Todo in Audits Aug 19, 2024
@fed-franz fed-franz self-assigned this Aug 20, 2024
@fed-franz fed-franz mentioned this issue Aug 20, 2024
Merged
@fed-franz fed-franz linked a pull request Aug 20, 2024 that will close this issue
Change verify_block_header to verify_candidate_header #2167
Merged
@fed-franz fed-franz moved this from Todo to In Review in Audits Aug 20, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Audits Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fed-franz fed-franz

Labels
module:node Issues related to node module
Projects
Audits
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change verify_block_header to verify_candidate_header dusk-network/rusk
1 participant
@fed-franz