Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return data from executed transactions #2072

Closed
miloszm opened this issue Aug 5, 2024 · 1 comment · Fixed by dusk-network/dusk-deploy-cli#3
Closed

Return data from executed transactions #2072

miloszm opened this issue Aug 5, 2024 · 1 comment · Fixed by dusk-network/dusk-deploy-cli#3
Labels
module:rusk Issues related to rusk module type:feature implementing a new feature

Comments

@miloszm
Copy link
Contributor

miloszm commented Aug 5, 2024

Summary

Currently, after executing transactions, we do not have return data which results from transaction's execution. In particular, in case of contract deployment transaction, we do not have information about deployment contract id, and no deployment specific error information, should transaction be successful yet deployment was not done, for example in case of contract-already-exists error.

Possible solution design or implementation

Devise a scheme to pass the return data back to transaction executor. Possibly, enrich the SpentTransaction struct with a field carrying the return data.

Additional context

This issue is related to the deployment epic #1071, yet it is also wider in scope, as it pertains to transactions in general.

@miloszm miloszm changed the title Return data from propagated transactions Return data from executed transactions Aug 5, 2024
@miloszm
Copy link
Contributor Author

miloszm commented Aug 5, 2024

Some additional points (from Seppia):

  • When transaction is propagated nothing happened yet.
  • You will have those informations only after the transaction is executed, and not after the propagation
  • You should then look for the transaction id after the transaction is executed
  • Ps: Probably you want to add some returned data into the “SpentTransaction” struct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:rusk Issues related to rusk module type:feature implementing a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants