Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not start from Iteration 0 when the node restarts #1908

Closed
fed-franz opened this issue Jul 2, 2024 · 1 comment · Fixed by #2229
Closed

Do not start from Iteration 0 when the node restarts #1908

fed-franz opened this issue Jul 2, 2024 · 1 comment · Fixed by #2229
Assignees
Labels
fix:bug Something isn't working

Comments

@fed-franz
Copy link
Contributor

fed-franz commented Jul 2, 2024

Summary

Currently, when the node restarts, it restarts consensus from iteration 0. However, this behavior leads to unwanted consequences, as the provisioner is most likely out of sync wrt the network.

Possible Solution

Upon restart, the node should first synchronize its blockchain and, if its tip is synced, wait for the current round to end before start participating in the consensus.

Alternatively, the node could "listen" for consensus messages, infer the current iteration, and "join" at that or the following one.

@autholykos autholykos added the fix:bug Something isn't working label Jul 5, 2024
@goshawk-3 goshawk-3 self-assigned this Aug 1, 2024
@autholykos
Copy link
Member

This is important in the context of hard-slashing and faults collection. The problem of restarting from iteration 0 is linked to the propagation of different votes (before the restart and after the restart; in the latter case the vote would most likely be that of a timeout).

The proper way to tackle this issue would be to synchronize after a restart, rather than jump on running consensus immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants