Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Economic Protocol Scenario 3 Deposit-Free #1644

Open
Tracked by #1690
miloszm opened this issue Apr 15, 2024 · 2 comments
Open
Tracked by #1690

Implement Economic Protocol Scenario 3 Deposit-Free #1644

miloszm opened this issue Apr 15, 2024 · 2 comments
Assignees
Labels
module:rusk Issues related to rusk module type:feature implementing a new feature

Comments

@miloszm
Copy link
Contributor

miloszm commented Apr 15, 2024

Summary

In addition to issue #1603 implementing contract-pays scenario, but still requiring user's deposit, we also need an implementation which does not require a deposit.

Possible solution design or implementation

We should make it possible to only call the "execute" part of the "spend_and_execute" call into transfer contract.

Additional context

Both deposit and deposit-free versions have their business use cases and should be allowed, hence we should have relevant tests for both these variants.

@miloszm miloszm added type:feature implementing a new feature module:rusk Issues related to rusk module labels Apr 15, 2024
@miloszm miloszm self-assigned this Apr 15, 2024
@ureeves
Copy link
Member

ureeves commented Jun 10, 2024

We decided to make this the main and only feature of the economic protocol.

As such we're broadening the scope of this issue to also remove of the parts of the protocol relating to the contract "charging" an additional fee, a.k.a. scenario 3 - contract applies fee. This will mean the elimination of part of the code introduced by #1735, and adjusting the rest of the codebase accordingly.

This change should be accompanied by some changes in piecrust reflecting the narrowed functionality, these changes being described in dusk-network/piecrust#365.

@autholykos
Copy link
Member

Blocked by #1657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:rusk Issues related to rusk module type:feature implementing a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants