Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement migration code for the stake contract optimisation #1448

Closed
miloszm opened this issue Feb 21, 2024 · 1 comment
Closed

Implement migration code for the stake contract optimisation #1448

miloszm opened this issue Feb 21, 2024 · 1 comment
Assignees
Labels
module:contracts Issues related to the genesis contracts

Comments

@miloszm
Copy link
Contributor

miloszm commented Feb 21, 2024

Summary

As per issue #1447, stake contract needs to be optimised. In order for this optimisation to take effect, the contract needs to be migrated, as otherwise stake data would be lost.

Possible solution design or implementation

Before a block is finalised, the block height should be checked against some assumed height, and if it matches, say block height is 20000, a migration is performed, using the migrate method of Session object.

Additional context

We need to take care of the ownership of the new contract - see Piecrust issue 336

@HDauven
Copy link
Member

HDauven commented Apr 8, 2024

Resolved by #1464

@HDauven HDauven closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:contracts Issues related to the genesis contracts
Projects
None yet
Development

No branches or pull requests

3 participants