From 10960d19f50329fef9aa0c3b919e93a84b9eb70b Mon Sep 17 00:00:00 2001 From: Norton Andreev Date: Mon, 18 Nov 2024 18:36:32 +0200 Subject: [PATCH] web-wallet: Fix button hover in Dashboard Menu Resolves #2999 Update DashboardNav.svelte up --- web-wallet/CHANGELOG.md | 2 + .../DashboardNav/DashboardNav.svelte | 10 ++-- .../__snapshots__/DashboardNav.spec.js.snap | 48 +++++++++---------- .../__tests__/__snapshots__/page.spec.js.snap | 40 ++++++++-------- 4 files changed, 53 insertions(+), 47 deletions(-) diff --git a/web-wallet/CHANGELOG.md b/web-wallet/CHANGELOG.md index 8223801d5..7aa44ba9d 100644 --- a/web-wallet/CHANGELOG.md +++ b/web-wallet/CHANGELOG.md @@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Enhance Allocate flow on full amount allocation [#2938] - Broken link in the stake warning [#2990] - Change "Transaction created" copy [#2991] +- Fix button hover style in Dashboard Navigation Menu [#2999] - Fix Dashboard navigation menu padding [#3000] ## [0.7.0] - 2024-11-11 @@ -365,6 +366,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 [#2990]: https://github.com/dusk-network/rusk/issues/2990 [#2991]: https://github.com/dusk-network/rusk/issues/2991 [#2997]: https://github.com/dusk-network/rusk/issues/2997 +[#2999]: https://github.com/dusk-network/rusk/issues/2999 [#3000]: https://github.com/dusk-network/rusk/issues/3000 [#3006]: https://github.com/dusk-network/rusk/issues/3006 [#3010]: https://github.com/dusk-network/rusk/issues/3010 diff --git a/web-wallet/src/lib/components/DashboardNav/DashboardNav.svelte b/web-wallet/src/lib/components/DashboardNav/DashboardNav.svelte index 819c985e3..b846b4fa7 100644 --- a/web-wallet/src/lib/components/DashboardNav/DashboardNav.svelte +++ b/web-wallet/src/lib/components/DashboardNav/DashboardNav.svelte @@ -19,7 +19,7 @@ role="menuitem" > {label} - {#if icons && icons.length} + {#if icons?.length} {#each icons as icon (icon.path)} @@ -39,6 +39,7 @@ align-items: center; justify-content: space-between; padding: 0.5rem 0; + color: var(--on-surface-color) !important; &:first-child { padding-top: 0; @@ -47,10 +48,14 @@ &:last-child { padding-bottom: 0; } + + &:hover { + color: var(--anchor-color-on-surface) !important; + text-decoration: none !important; + } } &__item-label { - color: var(--on-surface-color); font-size: 1.125rem; font-style: normal; font-weight: 500; @@ -58,7 +63,6 @@ } &__item-icons { - color: var(--on-surface-color); display: flex; flex-direction: row; gap: 0.625rem; diff --git a/web-wallet/src/lib/components/__tests__/__snapshots__/DashboardNav.spec.js.snap b/web-wallet/src/lib/components/__tests__/__snapshots__/DashboardNav.spec.js.snap index bf9d1cdc7..266989ac7 100644 --- a/web-wallet/src/lib/components/__tests__/__snapshots__/DashboardNav.spec.js.snap +++ b/web-wallet/src/lib/components/__tests__/__snapshots__/DashboardNav.spec.js.snap @@ -20,7 +20,7 @@ exports[`DashboardNav > renders the DashboardNav component 1`] = ` tabindex="0" > Something @@ -35,7 +35,7 @@ exports[`DashboardNav > renders the DashboardNav component 1`] = ` tabindex="0" > Send @@ -50,13 +50,13 @@ exports[`DashboardNav > renders the DashboardNav component 1`] = ` tabindex="0" > Receive renders the DashboardNav component 1`] = ` tabindex="0" > Stake should display icons if the item's icon array is present tabindex="0" > Something @@ -165,7 +165,7 @@ exports[`DashboardNav > should display icons if the item's icon array is present tabindex="0" > Send @@ -180,13 +180,13 @@ exports[`DashboardNav > should display icons if the item's icon array is present tabindex="0" > Receive should display icons if the item's icon array is present tabindex="0" > Stake should not display icons if the item's icon array is emp tabindex="0" > Something @@ -295,7 +295,7 @@ exports[`DashboardNav > should not display icons if the item's icon array is emp tabindex="0" > Send @@ -310,13 +310,13 @@ exports[`DashboardNav > should not display icons if the item's icon array is emp tabindex="0" > Receive should not display icons if the item's icon array is emp tabindex="0" > Stake should not display icons if the item's icons array is un tabindex="0" > Something @@ -425,7 +425,7 @@ exports[`DashboardNav > should not display icons if the item's icons array is un tabindex="0" > Send @@ -440,13 +440,13 @@ exports[`DashboardNav > should not display icons if the item's icons array is un tabindex="0" > Receive should not display icons if the item's icons array is un tabindex="0" > Stake should render a card when there is an error getting transac tabindex="0" > Send should render a card when there is an error getting transac tabindex="0" > Receive should render a card when there is an error getting transac tabindex="0" > Stake should render a card when there is an error getting transac tabindex="0" > Shield / Unshield should render a card when there is an error getting transac tabindex="0" > Migrate should render the dashboard page with the transactions afte tabindex="0" > Send should render the dashboard page with the transactions afte tabindex="0" > Receive should render the dashboard page with the transactions afte tabindex="0" > Stake should render the dashboard page with the transactions afte tabindex="0" > Shield / Unshield should render the dashboard page with the transactions afte tabindex="0" > Migrate