From 8e8eeeee200330569371fbff36c10deee6fa8165 Mon Sep 17 00:00:00 2001
From: Norton Andreev <norton@nortonandreev.com>
Date: Tue, 14 May 2024 19:16:03 +0300
Subject: [PATCH] explorer: Resolve details pages inconsistencies

Resolves #1738
---
 .../__tests__/__snapshots__/BlockDetails.spec.js.snap |  2 +-
 .../__tests__/__snapshots__/BlocksCard.spec.js.snap   |  4 +++-
 .../__snapshots__/TransactionsCard.spec.js.snap       |  4 +++-
 .../lib/components/block-details/BlockDetails.svelte  | 11 +----------
 explorer/src/lib/components/data-card/DataCard.css    |  1 -
 5 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/explorer/src/lib/components/__tests__/__snapshots__/BlockDetails.spec.js.snap b/explorer/src/lib/components/__tests__/__snapshots__/BlockDetails.spec.js.snap
index 408132dd81..60ab0862ff 100644
--- a/explorer/src/lib/components/__tests__/__snapshots__/BlockDetails.spec.js.snap
+++ b/explorer/src/lib/components/__tests__/__snapshots__/BlockDetails.spec.js.snap
@@ -12,7 +12,7 @@ exports[`Block Details > renders the Block Details component 1`] = `
       <h1
         class="data-card__header-title"
       >
-        Block Details - #495,868
+        Block Details
       </h1>
        
       <button
diff --git a/explorer/src/lib/components/__tests__/__snapshots__/BlocksCard.spec.js.snap b/explorer/src/lib/components/__tests__/__snapshots__/BlocksCard.spec.js.snap
index c5a93bc881..3a4eb921ec 100644
--- a/explorer/src/lib/components/__tests__/__snapshots__/BlocksCard.spec.js.snap
+++ b/explorer/src/lib/components/__tests__/__snapshots__/BlocksCard.spec.js.snap
@@ -830,7 +830,9 @@ exports[`Blocks Card > should disable the \`Show More\` button is the card is in
     <!--&lt;Button&gt;-->
   </header>
    
-  <p>
+  <p
+    class="data-card__loading-notice"
+  >
     Loading...
   </p>
   
diff --git a/explorer/src/lib/components/__tests__/__snapshots__/TransactionsCard.spec.js.snap b/explorer/src/lib/components/__tests__/__snapshots__/TransactionsCard.spec.js.snap
index e745c6679a..6ce260e6e7 100644
--- a/explorer/src/lib/components/__tests__/__snapshots__/TransactionsCard.spec.js.snap
+++ b/explorer/src/lib/components/__tests__/__snapshots__/TransactionsCard.spec.js.snap
@@ -28,7 +28,9 @@ exports[`Transactions Card > should disable the \`Show More\` button if the card
     <!--&lt;Button&gt;-->
   </header>
    
-  <p>
+  <p
+    class="data-card__loading-notice"
+  >
     Loading...
   </p>
   
diff --git a/explorer/src/lib/components/block-details/BlockDetails.svelte b/explorer/src/lib/components/block-details/BlockDetails.svelte
index 47a5f1d461..3524a169e7 100644
--- a/explorer/src/lib/components/block-details/BlockDetails.svelte
+++ b/explorer/src/lib/components/block-details/BlockDetails.svelte
@@ -32,17 +32,8 @@
   /** @type {Number} */
   let screenWidth = window.innerWidth;
 
-  /** @type {string}*/
-  let blockHeight = "";
-
   $: classes = makeClassName(["block-details", className]);
 
-  $: {
-    if (data) {
-      blockHeight = `#${formatter(data.header.height)}`;
-    }
-  }
-
   onMount(() => {
     const resizeObserver = new ResizeObserver((entries) => {
       const entry = entries[0];
@@ -62,7 +53,7 @@
   {error}
   {loading}
   className={classes}
-  title="Block Details - {blockHeight}"
+  title="Block Details"
   headerButtonDetails={{
     action: () => history.back(),
     disabled: false,
diff --git a/explorer/src/lib/components/data-card/DataCard.css b/explorer/src/lib/components/data-card/DataCard.css
index 43f27fe228..fcb1e9384f 100644
--- a/explorer/src/lib/components/data-card/DataCard.css
+++ b/explorer/src/lib/components/data-card/DataCard.css
@@ -18,5 +18,4 @@
   text-transform: uppercase;
   font-size: 1.125rem;
   line-height: 32.2px;
-  letter-spacing: -1%;
 }