Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend v challenge calculations #825

Closed
marta-belles opened this issue Jun 17, 2024 · 1 comment
Closed

Amend v challenge calculations #825

marta-belles opened this issue Jun 17, 2024 · 1 comment
Assignees
@xevisalle

Comments

@marta-belles
Copy link
Contributor

The calculation of one of the challenges is not done in the same order as specified in the PlonK paper. Since there are already two articles describing attacks derived from the order in which challenges are computed [1] [2], it is important that the code faithfully reflects the specification.
@xevisalle xevisalle linked a pull request Jun 27, 2024 that will close this issue
Make code to match the last Plonk paper #830
Merged
@xevisalle xevisalle changed the title Amend moment in which challenges are computed Make code to match the last version of the paper Jul 8, 2024
@xevisalle xevisalle changed the title Make code to match the last version of the paper Amend v challenge calculations Jul 8, 2024
@xevisalle
Copy link
Member

Closed in favor of: #831

@xevisalle xevisalle removed a link to a pull request Jul 8, 2024
Make code to match the last Plonk paper #830
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xevisalle xevisalle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xevisalle @marta-belles