Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tree::closest_peers function #44

Open
herr-seppia opened this issue Oct 25, 2021 · 0 comments
Open

Improve Tree::closest_peers function #44

herr-seppia opened this issue Oct 25, 2021 · 0 comments
Labels
status:minor Low priority improvements team:WebTech End to End UX / UI and blockchain type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@herr-seppia
Copy link
Member

Describe what you want implemented
Redesign the function in charge of find the closest peers related to an ID.

Describe "Why" this is needed
The actual implementation is sorting the whole content of all buckets inside the Tree.
This can be a performance bottleneck in case of full network allocation.
Consider to find closest peers starting from target's adjacent buckets and to iteratively move step aside if they're empty.

Describe alternatives you've considered
Keep going with the actual implementation

Additional context
Add any other context or screenshots about the feature request here.

@herr-seppia herr-seppia added team:WebTech End to End UX / UI and blockchain type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) labels Oct 25, 2021
@autholykos autholykos added the status:minor Low priority improvements label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:minor Low priority improvements team:WebTech End to End UX / UI and blockchain type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

No branches or pull requests

2 participants